search

ByMykel / CSGO-API

An unofficial JSON API for Counter-Strike 2 in multiples languages. List of skins, cases, stickers, collections, collectibles, agents, graffiti, keys, patches and music kits.
https://bymykel.github.io/CSGO-API/
MIT License
255 stars 29 forks source link

Incorrect name on stickers, agents... #106

Closed piyanggoon closed 5 months ago

piyanggoon commented 5 months ago

Some items have double space on name " |"

example.

Ground Rebel | Elite Crew Sticker | Ninjas in Pyjamas | Katowice 2015 Sticker | PENTA Sports | Katowice 2015

ByMykel commented 5 months ago

I am checking this and I am not able to see were is the error. I have checked the stcikers names in the SCM and they are the same.

WhoisUnknown commented 5 months ago

Trade market items have hash_name with double space i.g. https://steamcommunity.com/market/search/render/?query=Ground%20Rebel%20%20|%20Elite%20Crew&start=0&count=10&search_descriptions=0&sort_column=price&sort_dir=asc&appid=730&norender=1

ByMykel commented 5 months ago

So this is a Valve error with the translations, isn't it?

keys exctracted from csgo_english.json:

"CSGO_CustomPlayer_tm_leet_variantg": "Ground Rebel  | Elite Crew",
"StickerKit_eslkatowice2015_ninjasinpyjamas": "Ninjas in Pyjamas  | Katowice 2015",
"StickerKit_eslkatowice2015_pentasports": "PENTA Sports  | Katowice 2015",
piyanggoon commented 5 months ago

If SCM has double space, maybe we should use double space in 'hash_name' and replace spaces in 'name'.

piyanggoon commented 5 months ago

Trade market items have hash_name with double space i.g. https://steamcommunity.com/market/search/render/?query=Ground%20Rebel%20%20|%20Elite%20Crew&start=0&count=10&search_descriptions=0&sort_column=price&sort_dir=asc&appid=730&norender=1

I don't know before have API for fetch like this.

piyanggoon commented 5 months ago

@ByMykel i will use this API for generate graffiti and dump to json for you. done in 1-2 hours.

ByMykel commented 5 months ago

@ByMykel i will use this API for generate graffiti and dump to json for you. done in 1-2 hours.

Check also this https://github.com/ByMykel/CSGO-API/discussions/109, we can move this discussion there

piyanggoon commented 5 months ago

If SCM has double space, maybe we should use double space in 'hash_name' and replace spaces in 'name'.

@ByMykel what you think?

ByMykel commented 5 months ago

If SCM has double space, maybe we should use double space in 'hash_name' and replace spaces in 'name'.

@ByMykel what you think?

We don't have hash_name in stickers and I don't see the problem on leaving 2 spaces in the name.

Also in SCM they have also 2 spaces but the html only renders one.

image