[It broke]: MangaDex not downloading all chapters and names the files wrong, if chapter number is reoccurring in volumes

[absturztau-be]

What is broken?

Found out that tranga doesn't download all chapters from mangadex and missnames chapters, if the manga has another volume with restarting chapter numbers (for example vol11 in Happy Sugar Life)

in case of happy sugar life, it looks like tranga has downloaded vol1 ch1 but renamed it to vol11 ch1. all actual chapters from vol11 are not downloaded

no logs, since they seem to be irrelevant to this bug

Log-output

No response

Additional stuff

running on latest tag

[C9Glax]

Think I found the issue. Gotta take a moment to think about how to solve both problems... https://github.com/C9Glax/tranga/commit/ec8eb4094136466ff9c5908dfc3ec0247fc9fe62 Knew there was a reason why I checked both .- .

[C9Glax]

The issue being that Mangadex itself sometimes assigns volume-numbers, then removes them, triggering a re-download, and causing duplicate chapters...

[absturztau-be]

i see, that indeed is troublesome.

i don't mind, if it misses some downloads because of this, because i think this is quite a niche case (the double chapter numbers, i mean), but at least tranga should rename the chapters to its first occurrence instead to the last so it matches to what is actually downloaded

[C9Glax]

Okay I think I found a way to preserve both. But I don't know how it will handle Filename collisions atm...