Closed penguian closed 4 years ago
@amu561@nci.org.au changed component from MPI
to offline
@jxs599@nci.org.au changed milestone from ` to
6. Report`
@jxs599@nci.org.au changed milestone from 6. Report
to 3. Implementation
@jxs599@nci.org.au commented
Resolution in: https://trac.nci.org.au/trac/cable/browser/branches/Users/amu561/CMIP6-MOSRS_CNP_INTERFACE?rev=5349 However, may not work for non-tiled runs. Can implement IF clause to work around.
@jxs599@nci.org.au changed owner from bep599
to amu561
@jxs599@nci.org.au commented
See #226 - S ofar for HAC we have used th single ste forcing of Loobos. This is as standard/ubiquitous for JULES as Tumbarumba is for us.
The point was reached where it was necessary to compare CABLE through CABLE IO vs CABLE through JULES IO - and hopefully get the same result. (At least on the albedo pathway for now).
So we arranged a CABLE-ised version of the Loobos forcing data. However, whereas JULES I/O correctly acknowledged 4 tiles (1,2,6,14) - CABLE did not(6) - due to this same issue of not being able implement multiple tiles through the forcing file.
I got this working in my case, building on top of #226
here and added this as a ticket #232
@jxs599@nci.org.au commented
cable_parameters.F90: ll ~1243
!! I brought this in with manual merge of #199 BUT Am i bringing this back in ? | --------------------------------------------------------------------------------------------------------------------
!!! calculate vegin%froot from using rootbeta and soil depth | ! calculate vegin%froot from using rootbeta and soil depth
!!! (Jackson et al. 1996, Oceologica, 108:389-411) | ! (Jackson et al. 1996, Oceologica, 108:389-411)
!!totdepth # 0.0 | totdepth 0.0
!!DO is # 1, ms | DO is 1, ms
!! totdepth # totdepth + soil%zse(is) * 100.0 ! unit in centimetres | totdepth totdepth + soil%zse(is) * 100.0 ! unit in centimetres
!! vegin%froot(is, :) # MIN(1.0, 1.0-vegin%rootbeta(:)**totdepth) | vegin%froot(is, :) MIN(1.0, 1.0-vegin%rootbeta(:)**totdepth)
!!END DO | END DO
!!DO is # ms, 2, -1 | DO is ms, 2, -1
!! vegin%froot(is, :) # vegin%froot(is, :)-vegin%froot(is-1, :) | vegin%froot(is, :) vegin%froot(is, :)-vegin%froot(is-1, :)
!!END DO
@jxs599@nci.org.au commented
Possibly also include this on a switch??
@jxs599@nci.org.au changed status from new
to closed
@jxs599@nci.org.au set resolution to fixed
@jxs599@nci.org.au changed type from defect
to model improvement
@jxs599@nci.org.au changed milestone from 3. Implementation
to 1. Closed
@jxs599@nci.org.au commented
pushed to trunk @3d9b325e5c1757f3838c02b6b8ea9156cc04117e
@ccc561@nci.org.au set keywords to nogit
keyword_nogit
owner:amu561@nci.org.au
resolution_fixed
type_model improvement
| by amu561An error is produced when tiled vegetation is passed through the met file for a site run.
This is because the patches are first read from the met file, and the code then tries to overwrite these from the global gridinfo file. When these don't match, the code crashes due to a dimension error.
Suggest bypassing reading veg info from the gridinfo file when it is present in the met file.
This behaviour occurred using the shared CMIP6-MOSRS branch.
Issue migrated from trac:199 at 2023-11-27 11:26:35 +1100