Some met variables 4D in site runs

[penguian]

keyword_nogit owner:bep599@nci.org.au resolution_fixed type_defect | by amu561

---

Some met variables need to be passed as 4-dimensional (x, y, z, time) and others as 3-dimensional (x, y, time) for site runs. I'm wondering if this is necessary? 4D variables include Tair, PSurf, Qair and CO2air.

Given the z-dimension is set to 1, it seems redundant. It can also lead to errors in the runs if z-dim is not set, as CABLE will read the first time step throughout the simulation, without producing an error or a warning.

I suggest the z-dimension could be removed, or else CABLE should stop with an error if it's not passed.

---

Issue migrated from trac:200 at 2023-11-27 11:26:43 +1100

[penguian]

@jxs599@nci.org.au changed milestone from ` to6. Report`

[penguian]

@amu561@nci.org.au commented

---

This change to 3D should be made so that CABLE complies with the latest ALMA convention

[penguian]

@jxs599@nci.org.au commented

---

Gab's change was simply a fix for ticket #200:

https://trac.nci.org.au/trac/cable/browser/branches/Users/gxa561/CABLE2.5_3D_met_fix

Fixed so that 4D (older ALMA format) or 3D (current ALMA format), or a mix of the two, will work. In doing this I found a bug of sorts: the default met file we have in the repo has 3D PSurf, which was one of the met variables that were expected as 4D, which meant that running CABLE offline with this file used the first time step of PSurf for all time steps. So the fix will not give will not give the same results as the trunk if you test with this file, since PSurf now varies with time, as it should.

pushed to trunk@7162

[penguian]

@jxs599@nci.org.au changed status from new to closed

[penguian]

@jxs599@nci.org.au set resolution to fixed

[penguian]

@jxs599@nci.org.au changed milestone from 6. Report to 1. Closed

[penguian]

@ccc561@nci.org.au set keywords to nogit