Open penguian opened 6 years ago
@bep599@nci.org.au edited the issue description
@bep599@nci.org.au commented
There are also 8 instances in SUBROUTINE snowdensity within cable_soilsnow.F90 where the number 273.15 has been used. Suggest to use C%belowFRZ, with assigned value of 273.15, to replace all 10 instances. Later on, someone can test if some other value (eg. 273.159 or 273.15999, etc.) could be more appropriate.
@inh599@nci.org.au commented
In this particular case we need to ensure that the value of ar1 and ar2 is negative or = 0
There are three solutions
@ccc561@nci.org.au changed keywords from snow albedo
to snow albedo keepgit
keyword_snow_albedo_keepgit
type_defect
| by bep599The original version in CABLE1.4b has: tmp = ssoil%isflag ssoil%tggsn(:,1) + (1 - ssoil%isflag ) ssoil%tgg(:,1)
Somehow, when translated into CABLE2.0, it becomes: tmp = ssnow%isflag ssnow%tggsn(:,1) + ( 1 - ssnow%isflag ) ssnow%tgg(:,1)
Since tfrz is set to 273.16, the second and third lines are not complementary. When tmp is just below freezing point (between 273.15 and 273.16), there will be positive values of ar1 and ar2.
Issue migrated from trac:201 at 2023-11-27 11:26:50 +1100