search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

Missing unit conversion for NPP output in trunk #216

Closed penguian closed 5 years ago

penguian commented 5 years ago

keyword_nogit owner:bep599@nci.org.au resolution_fixed type_defect | by amu561

In cable_output.F90, the GPP output is divided by 1.201E-5, but NPP output is not as this part is commented out. The units should be equal so the conversion is needed for NPP (casaflux variable should not be included unless it is in a casa if-loop).

out%GPP = out%GPP + REAL((-1.0 * canopy%fpn + canopy%frday) &
                    / 1.201E-5, 4)
out%NPP = out%NPP + REAL((-1.0 * canopy%fpn - canopy%frp))! &
              !  - casaflux%clabloss/86400.0) / 1.201E-5, 4)

Issue migrated from trac:216 at 2023-11-27 11:28:27 +1100

penguian commented 5 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 5 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 5 years ago

@jxs599@nci.org.au set milestone to 1. Closed

penguian commented 5 years ago

@jxs599@nci.org.au commented

pushed to trunk @8416ed37b36f90c4ba23a84c6bfb3bd84c74b6ad

penguian commented 5 years ago

@jxs599@nci.org.au changed _comment0 which not transferred by tractive

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit