search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

separating C3 and C4 photosynthesis #218

Closed penguian closed 4 years ago

penguian commented 5 years ago

keyword_C3 keyword_C4_nogit owner:yxw599@nci.org.au resolution_invalid type_defect | by yxw599

Two revisions of CABLE: revision 3623 and 4014. Revision 3623. calculate the weighted parameter values using C3 or C4 area fractions

Revision 4014: calculate parameter values for C3 and C4 separately, then combined them using the area fraction.

Tests done by YPW in 2017 found that revision 4014 conserved the carbon and water fluxes when C3 fraction varies from 0 to 1 (or C4 fraction varies from 1 to 0), whereas revision 3623 does not, because of nonlinearity of the combined equations for leaf stomatal conductance, leaf photosynthesis and leaf energy balance.

Issue migrated from trac:218 at 2023-11-27 11:28:42 +1100

penguian commented 5 years ago

@yxw599@nci.org.au commented

Revision 4014 has all the changes required.

penguian commented 5 years ago

@yxw599@nci.org.au changed status from new to assigned

penguian commented 5 years ago

@yxw599@nci.org.au changed owner from bep599 to yxw599

penguian commented 5 years ago

@mgk576@nci.org.au commented

I've just implemented this into a branch that mirrors the trunk

https://trac.nci.org.au/trac/cable/browser/branches/Users/mgk576/trunk_c3_c4

I've carried out two tests:

  1. c4 frac = 0, i.e. the trunk and this ticket should be identical. They are.
  2. c4 frac = 0.3, i.e. the branch with this ticket should give something different - I don't see it.

Plot attached.

penguian commented 5 years ago

@mgk576@nci.org.au uploaded file tumba.png (58.8 KiB)

penguian commented 4 years ago

@jxs599@nci.org.au changed status from assigned to closed

penguian commented 4 years ago

@jxs599@nci.org.au set resolution to invalid

penguian commented 4 years ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 1 year ago

@ccc561@nci.org.au changed keywords from C3, C4 to C3, C4 nogit