Open penguian opened 5 years ago
@jxs599@nci.org.au set milestone to 6. Report
@ccc561@nci.org.au commented
I don't know if we want to implement this but the proposed code has a bug. It only calculates Ci:Ca for the last patch (i=mp). Need to remove i as an input and add a loop over mp in the subroutine.
Also, since this isn't used in canopy, can the subroutine be called from cbm or somewhere outside canopy?
@jxs599@nci.org.au commented
If this was a JULES submission we would all be hinged on the decision from the module leader. I would reccomend YP make the call if we even want it or not
@ccc561@nci.org.au _changed keywords from ci_ca
to ci_ca maygit
_
keyword_ci_ca_maygit
type_model improvement
| by mgk576I've added the ratio of intercellular to atmospheric CO2 (Ci:Ca) to the output file. This is calculated internally in the canopy space but is potentially a useful diagnostic variable to output. I've added a subroutine to calculate it in cable_canopy and then the other additions are to the output routines. This should be in sync with the trunk otherwise.
https://trac.nci.org.au/trac/cable/browser/branches/Users/mgk576/trunk_CiCa
Issue migrated from trac:219 at 2023-11-27 11:28:48 +1100