search

CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

nparam in cable_mpicommon does not match declaration #223

Closed penguian closed 4 years ago

penguian commented 4 years ago

keyword_nogit owner:bep599@nci.org.au resolution_fixed type_defect | by mgk576

In the trunk...

cable_mpicommon.F90,

INTEGER, PARAMETER :: nparam = 331

If I then count all the CALL MPI_Get_address in cable_mpiworker, i.e. btw line 1008 and 2431

gawk 'NR >= 1008 && NR <= 2431' ~/research/CABLE_runs/src/trunk/trunk/offline/cable_mpiworker.F90 | gawk '$1=="CALL"' | wc -l

I get 332.

So it would appear they don't match in the trunk?

Issue migrated from trac:223 at 2023-11-27 11:29:17 +1100

penguian commented 4 years ago

@mgk576@nci.org.au commented

As requested, I tested increasing nparam by 1 and it fails....

master: invalid number of param_t fields 331 , fix it! worker 2 invalid number of param_t fields 331 , fix it! worker 6 invalid number of param_t fields 331 , fix it! worker 11 invalid number of param_t fields 331 , fix it! worker 13 invalid number of param_t fields 331 , fix it! worker 15 invalid number of param_t fields 331 , fix it! worker 18 invalid number of param_t fields 331 , fix it! worker 19 invalid number of param_t fields 331 , fix it! worker 23 invalid number of param_t fields 331 , fix it! worker 25 invalid number of param_t fields 331 , fix it! worker 26 invalid number of param_t fields 331 , fix it! worker 1 invalid number of param_t fields 331 , fix it! worker 3 invalid number of param_t fields 331 , fix it! worker 4 invalid number of param_t fields 331 , fix it!

etc.

penguian commented 4 years ago

@mgk576@nci.org.au commented

OK ... the issue is that you have a duplicate call

CALL MPI_Get_address (soil%GWdz, displs(bidx), ierr)

penguian commented 4 years ago

@mgk576@nci.org.au commented

offline/cable_mpimaster.F90 offline/cable_mpiworker.F90

penguian commented 4 years ago

@rml599@nci.org.au commented

test removing duplicate line

penguian commented 4 years ago

@jxs599@nci.org.au set milestone to 3. Implementation

penguian commented 4 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 4 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 4 years ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 4 years ago

@jxs599@nci.org.au commented

pushed to trunk@6946

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to nogit