Here we begin to split up files as per JAC requirements

[penguian]

keyword_nogit owner:jxs599@nci.org.au resolution_duplicate type_code improvement | by srb001@csiro.au

---

217 successfully modifies structure of CABLE directories. No changes to source code here

Here we begin to split up the files

https://trac.nci.org.au/trac/cable/browser/branches/Users/jxs599/HAC/trunkSeptember10.4

See comments below.

https://trac.nci.org.au/svn/cable/branches/Users/jxs599/CABLE/Tickets/2019/224

is the revised branch for this ticket

The plots referenced below up to and including comment 7 have been moved to:

https://accessdev.nci.org.au/p66/jxs599/PreviouslyOffRoot/

---

Issue migrated from trac:224 at 2023-11-27 11:29:25 +1100

[penguian]

@jxs599@nci.org.au edited the issue description

[penguian]

@jxs599@nci.org.au commented

---

files are split up in rad and albedo as a stepping stone to draw in Hac modifications. The changes to the code are minimal and restricted to offline building requirements. We should be able to maintain types in offline by using different versions of "cbm".

[penguian]

@jxs599@nci.org.au changed _comment0 which not transferred by tractive

[penguian]

@jxs599@nci.org.au commented

---

Following splitting up files, the modifications in HAC were included. The model was modified such that it was no longer bit reproducible.

Further investigation show the first deviation from "bitwise reproducibility".

These plots show that indeed there is no discernible change to the model, which highlights the extreme sensitivity of the quantity surveyed in this respect, "new_sumbal".

[penguian]

@jxs599@nci.org.au changed _comment0 which not transferred by tractive

[penguian]

@jxs599@nci.org.au changed _comment1 which not transferred by tractive

[penguian]

@jxs599@nci.org.au commented

---

217 is demonstrative only and doesn't actually build.

The branch linked to #224 actually goes further than what I would like to achieve this Ticket - which is a restructured CABLE that bitwise reproduces the trunk. In all fairness this has to be revised to be "effectively" reproduces the trunk.

Above comment3 links to the first move away from bitwise reproducibility - however shows that there is no discernible corresponding difference in the model output. There is a second such move away from bitwise reproducibility - that also results in zero discernible corresponding difference in the model output. This is due to moving declaration of two variables having KIND=(selected_real_kind) declaration to being simply KIND=REAL.

This is preferable at this stage as the selected_real_kind decs are generally problematic anyway, however LFric intends to employ selected_real_kind in future and this almost guarantees that OUR version of selected_real_kind (r_2) will be even more so (problematic). AND there e is really no need for it - i think.

HOWEVER - as treated here there is NO difference from the trunk. The 2 differences discussed above apply to later implementation which is now addressed in #226.

So what we did was svn co https://trac.nci.org.au/svn/cable/branches/Users/jxs599/HAC/trunkSeptember10.4@6361 T224_JaCed_structure_6361/

169356f0d6b0d5e203baffcdc21d9d217ad7a095 - corresponds to splitting up the files etc but not actually changing anything

svn copy $SVN_CABLE/trunk https://trac.nci.org.au/svn/cable/branches/Users/jxs599/CABLE/Tickets/2019/224

svn co https://trac.nci.org.au/svn/cable/branches/Users/jxs599/CABLE/Tickets/2019/224

/bin/cp -r T224_JaCed_structure_6361/ 224/

we then modified the build process so we could verify that we were't actually changing anything

[penguian]

@jxs599@nci.org.au changed _comment0 which not transferred by tractive

[penguian]

@jxs599@nci.org.au changed _comment1 which not transferred by tractive

[penguian]

@jxs599@nci.org.au changed _comment2 which not transferred by tractive

[penguian]

@jxs599@nci.org.au changed _comment3 which not transferred by tractive

[penguian]

@jxs599@nci.org.au commented

---

https://trac.nci.org.au/svn/cable/branches/Users/jxs599/CABLE/Tickets/2019/224

is the revised branch for this ticket

[penguian]

@jxs599@nci.org.au edited the issue description

[penguian]

@jxs599@nci.org.au changed milestone from 3. Implementation to 2. Submission

[penguian]

@jxs599@nci.org.au changed status from assigned to new

[penguian]

@jxs599@nci.org.au changed owner from jxs500 to jxs599

[penguian]

@jxs599@nci.org.au commented

---

The quantity "sumbal" changes a few times throughout this process. In all instances there are zero differences observed in the output - as decribed in above comments.

The biggest difference observed can be seen in the Soil moisture. This occurs between revisions 6446 and 6447 when we switch between sections of code appropriate to sunlit processes triggering off the zenith angle rather than downward shortwave. Even so, the differences are minor.

[penguian]

@jxs599@nci.org.au changed _comment0 which not transferred by tractive

[penguian]

@jxs599@nci.org.au edited the issue description

[penguian]

@jxs599@nci.org.au edited the issue description

[penguian]

@jxs599@nci.org.au edited the issue description

[penguian]

@jxs599@nci.org.au edited the issue description

[penguian]

@jxs599@nci.org.au changed status from new to closed

[penguian]

@jxs599@nci.org.au set resolution to duplicate

[penguian]

@jxs599@nci.org.au changed milestone from 2. Submission to 1. Closed

[penguian]

@ccc561@nci.org.au set keywords to nogit