Closed penguian closed 4 years ago
@mgk576@nci.org.au uploaded file Screen Shot 2019-09-26 at 10.44.26 am.png
(168.3 KiB)
@mgk576@nci.org.au changed status from new
to closed
@mgk576@nci.org.au set resolution to fixed
@mgk576@nci.org.au commented
I lost the code sadly :)
@jxs599@nci.org.au commented
to be revisited when there is ample time :)
@jxs599@nci.org.au set milestone to 1. Closed
@ccc561@nci.org.au set keywords to nogit
keyword_nogit
resolution_fixed
type_model improvement
| by mgk576The logic in remove trans was frankly horrific. You had variables called "xx", "xxd" and "diff", with the "diff" being used for a completely separate variable mid-loop. This was really unnecessarily confusing. I've fixed the logic and even added some comments to explain what the original coder intended.
Plots look indistinguishable - left is the trunk, right is improved code.
https://trac.nci.org.au/svn/cable/branches/Users/mgk576/trunk_remove_trans/core/biogeophys/cable_soilsnow.F90
Issue migrated from trac:225 at 2023-11-27 11:29:36 +1100