Establish consistent dimensionality of radiation varables

[penguian]

keyword_nogit owner:jxs599@nci.org.au resolution_fixed type_defect | by srb001@csiro.au

---

Do this on top of #226

radiation/albedo variables are treated throughout as having dimensionality nrb,3,2, direct beam diffuse.

Firstly nrb has not used a 3rd dimension for a decade or more. It should be ONLY VIS or NIR, i.e. =2. Direct beam and diffuse are not a radiation bandwidths anyway but often assume the dimensionality

---

Issue migrated from trac:230 at 2023-11-27 11:30:13 +1100

[penguian]

@jxs599@nci.org.au commented

---

In coupled/shared:

trb

cable_soilsnow_type_mod.F90:USE grid_constants_cbl_mod, ONLY: trb !total # rad "bands"

cable_soilsnow_type_mod.F90:ALLOCATE( var% albsoilsn(mp,trb) )

Note: there is no trb in grid_constants ONLY nrb

Strategy then is to USE this nrb across model and then swap it to =2. Investigate consequences.

[penguian]

@jxs599@nci.org.au changed _comment0 which not transferred by tractive

[penguian]

@jxs599@nci.org.au changed _comment1 which not transferred by tractive

[penguian]

@jxs599@nci.org.au changed _comment2 which not transferred by tractive

[penguian]

@jxs599@nci.org.au commented

---

In coupled/JULES-Standalone/:

nrb

initialisation/grid_constants_cbl.F90:INTEGER, PARAMETER :: nrb = 3 ! # rad bands VISual/NIR + Legacy incl LW

params/cable_other_constants_mod.F90: nrb = 3, & ! number of radiation bands normally in use

params/cable_other_constants_mod.F90:!REAL, PARAMETER :: gauss_w(nrb)=(/0.308,0.514,0.178 /) ! F90

params/cable_other_constants_mod.F90:REAL, PARAMETER :: gauss_w(nrb)=[0.308,0.514,0.178 ] ! F03

control/cable/shared/params_io_cbl.F90: nrb, & ! # spectral bANDS VIS/NIR/(LW-not used)

control/cable/shared/params_io_cbl.F90: vegin_refl(nrb,ntype_max), &

control/cable/shared/params_io_cbl.F90: vegin_taul(nrb,ntype_max)

[penguian]

@jxs599@nci.org.au commented

---

comment:1 DONE: removed trb references

cleaned up coupled/shared/cable_soilsnow_type_mod.F90 to remove hard-wired numbers AND remove unused arrays

params/grid_constants_cbl.F90 - more explicit. reviewed comments, added nsoils.

[penguian]

@jxs599@nci.org.au commented

---

comment:2 DONE - in so far as cable_other_constants USES nrb etc FROM grid_constants

params_io_cbl USEs nrb etc as it legitimately needs to

[penguian]

@jxs599@nci.org.au commented

---

test this offline. Push it.

Once we get #1223 through JULES, add these updates in #1226?

[penguian]

@jxs599@nci.org.au changed status from assigned to closed

[penguian]

@jxs599@nci.org.au set resolution to fixed

[penguian]

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

[penguian]

@jxs599@nci.org.au commented

---

pushed @ 8657

[penguian]

@ccc561@nci.org.au set keywords to nogit