Open penguian opened 4 years ago
@mgk576@nci.org.au commented
I spoke to Anna and I think this is just for the groundwater on case. I suggest we separate the steps as it is pretty hard to follow the logic here!
@jxs599@nci.org.au set milestone to 6. Report
@ccc561@nci.org.au commented
If I understand the error, the denominator is constant along the soil layers but it needs to be included in the MIN(), and hence the SUM(). The MIN() should be on the ratio of (wb-swilt)/(sfc-swilt) and not just (wb-swilt).
@jxs599@nci.org.au commented
I'll use Anna's suggestion and close it in the next few days
@ccc561@nci.org.au set keywords to keepgit
keyword_keepgit
type_defect
| by amu561In SUBROUTINE fwsoil_calc_std in cable_canopy.F90, the brackets are not placed correctly in this equation:
The (soil%sfc-soil%swilt) should be within the MIN() statetement. To correct this, the equation can be replaced with:
This leads to a minor correction in fwsoil at soil moisture values above field capacity.
Issue migrated from trac:236 at 2023-11-27 11:30:54 +1100