CABLE-LSM / CABLE-Trac-archive

Archive CABLE Trac contents as issues
Other
0 stars 0 forks source link

labile spinup flag #237

Closed penguian closed 4 years ago

penguian commented 4 years ago

keyword_maygit owner:bep599@nci.org.au resolution_fixed type_defect | by mgk576


In YP's spinup document:

"You firstly need to repeat all the five steps as for the case “icycle” =1, except uncomment out two lines before “end subroutine biogeochem” in “casa_inout.F90”.

After obtaining the steady state values, then comment out the two lines as uncommented out previously, and repeat the five steps as in “icycle”=1."

This is a bit of unpractical expectation of the user, so I propose instead to add a flag.

In cable_common. You need to add: limit_labile = .FALSE. to kbl_user_switches

And in casa_inout, the code becomes:

IF (cable_user%limit_labile) THEN casapool%Nsoilmin = max(casapool%Nsoilmin,0.5) casapool%Psoillab = max(casapool%Psoillab,0.1) ENDIF


Issue migrated from trac:237 at 2023-11-27 11:31:01 +1100

penguian commented 4 years ago

@mgk576@nci.org.au commented


Actually....this might be better

USE CASAVARIABLE, ONLY : icycle

and

IF (cable_user%limit_labile .AND. icycle > 1) THEN
    casapool%Nsoilmin = max(casapool%Nsoilmin,0.5)
    casapool%Psoillab = max(casapool%Psoillab,0.1)
ENDIF

in casa_inout.F90

penguian commented 4 years ago

@rml599@nci.org.au commented


Committee agreed to change, 4/2/20

penguian commented 4 years ago

@jxs599@nci.org.au set milestone to 3. Implementation

penguian commented 4 years ago

@jxs599@nci.org.au changed status from new to closed

penguian commented 4 years ago

@jxs599@nci.org.au set resolution to fixed

penguian commented 4 years ago

@jxs599@nci.org.au changed milestone from 3. Implementation to 1. Closed

penguian commented 4 years ago

@jxs599@nci.org.au commented


pushed to trunk@6947

penguian commented 1 year ago

@ccc561@nci.org.au set keywords to maygit