search

CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
22 stars 11 forks source link

Angus/workspace update #1299

Closed veggiesaurus closed 1 year ago

veggiesaurus commented 1 year ago

Description Trivial change to support workspace sharing PR https://github.com/CARTAvis/carta-controller/pull/155

veggiesaurus commented 1 year ago

With dev+dev, I have a restorable workspace. With this branch, however, the backend crashes when I select the workspace file in the file browser. The backend log shows:

[2023-08-22 00:17:00.381] [CARTA] [critical] [json.exception.type_error.302] type must be boolean, but is null

Fixed, sorry about that.

With this branch, when I try to save a workspace, there is an error saying the workspace cannot be saved but in the file list I see the workspace name shows up and in .carta folder I do see the (non-empty) workspace json file which actually can be restored with dev+dev. If I try to restore it with this branch, again the backend crashes.

I can reproduce this, but think it is a frontend bug. I will try fix it there quickly.

veggiesaurus commented 1 year ago

@kswang1029 can you retry with this branch and the latest commit of the frontend branch?

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
src.Cache 66% ➖
src.DataStream 52% ➖
src.FileList 67% ➖
src.Frame 50% ➖
src.HttpServer 42% ➖
src.ImageData 28% ❌
src.ImageFitter 89% ✔
src.ImageGenerators 44% ➖
src.ImageStats 76% ✔
src.Logger 44% ➖
src.Main 54% ➖
src.Region 18% ❌
src.Session 29% ❌
src.Table 52% ➖
src.ThreadingManager 87% ✔
src.Timer 85% ✔
src.Util 48% ➖
Summary 38% (7012 / 18560) ❌
kswang1029 commented 1 year ago

@kswang1029 can you retry with this branch and the latest commit of the frontend branch?

Yes, the issues are gone~ Will proceed tests including the controller.