CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
22 stars 11 forks source link

Carli/1296 add deployment to telemetry platform info #1300

Closed crocka closed 1 year ago

crocka commented 1 year ago

Description This PR solves #1296, by sending the --DDEPLOYMENT_TYPE flag from CMAKE, the carta-backend option --controller_deployment, and the env variable CARTA_DOCKER_DEPLOYMENT set in Dockerfiles, to the frontend through telemetry platform string.

Checklist

crocka commented 1 year ago

@kswang1029 @confluence Sorry I forgot to push the changes that sets the deployment string to "unknown". Please take a look again.

crocka commented 1 year ago

@ajm-asiaa Suggested we add an env variable in the docker container to identify docker deployments. Environmental variables in docker container are pretty safe from changes.

ajm-ska commented 1 year ago

Just to add, I suggested it because, for the Docker containers on cartavis/carta Docker Hub, we use @veggiesaurus's dockerfile_minimal to create them. That Dockerfile simply installs the Debian carta-backend. So if we were to use the cartavis/carta Docker container, telemetry would report it to be "deb" (as well as the platform being Linux and ubuntu 20.04.6 LTS)

confluence commented 1 year ago

@kswang1029 I am happy with the code changes. This may need an end-to-end re-test of the whole feature, since there have been multiple changes in what is sent to the frontend.

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
src.Cache 66%
src.DataStream 52%
src.FileList 67%
src.Frame 50%
src.HttpServer 43%
src.ImageData 28%
src.ImageFitter 89%
src.ImageGenerators 44%
src.ImageStats 76%
src.Logger 44%
src.Main 54%
src.Region 18%
src.Session 29%
src.Table 52%
src.ThreadingManager 87%
src.Timer 85%
src.Util 48%
Summary 38% (7029 / 18583)