Closed crocka closed 1 year ago
@kswang1029 @confluence Sorry I forgot to push the changes that sets the deployment string to "unknown". Please take a look again.
@ajm-asiaa Suggested we add an env variable in the docker container to identify docker deployments. Environmental variables in docker container are pretty safe from changes.
Just to add, I suggested it because, for the Docker containers on cartavis/carta Docker Hub, we use @veggiesaurus's dockerfile_minimal to create them. That Dockerfile simply installs the Debian carta-backend. So if we were to use the cartavis/carta
Docker container, telemetry would report it to be "deb" (as well as the platform being Linux and ubuntu 20.04.6 LTS)
@kswang1029 I am happy with the code changes. This may need an end-to-end re-test of the whole feature, since there have been multiple changes in what is sent to the frontend.
Package | Line Rate | Health |
---|---|---|
src.Cache | 66% | ➖ |
src.DataStream | 52% | ➖ |
src.FileList | 67% | ➖ |
src.Frame | 50% | ➖ |
src.HttpServer | 43% | ➖ |
src.ImageData | 28% | ❌ |
src.ImageFitter | 89% | ✔ |
src.ImageGenerators | 44% | ➖ |
src.ImageStats | 76% | ✔ |
src.Logger | 44% | ➖ |
src.Main | 54% | ➖ |
src.Region | 18% | ❌ |
src.Session | 29% | ❌ |
src.Table | 52% | ➖ |
src.ThreadingManager | 87% | ✔ |
src.Timer | 85% | ✔ |
src.Util | 48% | ➖ |
Summary | 38% (7029 / 18583) | ❌ |
Description This PR solves #1296, by sending the
--DDEPLOYMENT_TYPE
flag from CMAKE, the carta-backend option--controller_deployment
, and the env variableCARTA_DOCKER_DEPLOYMENT
set in Dockerfiles, to the frontend through telemetry platform string.Checklist
protobuf updated to the latest dev commit/ no protobuf update needed