CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
22 stars 11 forks source link

Yuhsuan/1318 fix fitting mad #1319

Closed YuHsuan-Hwang closed 1 year ago

YuHsuan-Hwang commented 1 year ago

Description

Checklist

kswang1029 commented 1 year ago

@YuHsuan-Hwang if the input image does not have any NaN pixels, do we expect to see slightly different fitting results in this PR comparing to dev?

I see the solution is to have a double array to exclude NaN. Would it be sensible to refer to BITPIX for the array declaration? Not sure this is the root cause for the above question?

YuHsuan-Hwang commented 1 year ago

@kswang1029

if the input image does not have any NaN pixels, do we expect to see slightly different fitting results in this PR comparing to dev?

Yes, there are slightly changes because my previous workaround triggers some preprocessing to the array.

I see the solution is to have a double array to exclude NaN. Would it be sensible to refer to BITPIX for the array declaration? Not sure this is the root cause for the above question?

Double array is required for the GSL function.

YuHsuan-Hwang commented 1 year ago

Debug log "MAD = ..." is added so that testing is easier.

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
src.Cache 66%
src.DataStream 52%
src.FileList 67%
src.Frame 50%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 83%
src.ImageGenerators 43%
src.ImageStats 76%
src.Logger 38%
src.Main 52%
src.Region 18%
src.Session 30%
src.Table 52%
src.ThreadingManager 87%
src.Timer 85%
src.Util 48%
Summary 38% (7094 / 18739)