CARTAvis / carta-frontend

Source code repository for the frontend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
20 stars 10 forks source link

Kuahchou/2396 new RESTFQ for moment #2404

Closed loveluthien closed 2 months ago

loveluthien commented 3 months ago

Description

This closed #2396 together with backend PR and its companion protobuf. This PR adds the rest frequency GUI to the moment generator.

Checklist

For linked issues (if there are):

For the pull request:

For dependencies:

loveluthien commented 3 months ago

Regarding changing the unit of rest frequency definition, there are possible use cases:

  1. user manually types in the value: in this case, user needs to configure the right unit first before typing. Or user needs to convert the value in mind if the selected unit is different from the one in user's mind (mostly the value is read from a catalog)
  2. user copies and pasts a value from a catalog: in this case, users need to configure the right unit first before pasting. If pasting happens first and changing the unit later, the value will be changed too.

In both cases. the new feature (synchronize the value and unit) does not help the UX and sometimes hurts. I suggest we keep the original way (desynchronize the value and unit)

Okay.

loveluthien commented 3 months ago

update:

YuHsuan-Hwang commented 2 months ago

Pending for https://github.com/CARTAvis/carta-backend/pull/1387 code review.