Closed loveluthien closed 2 months ago
Regarding changing the unit of rest frequency definition, there are possible use cases:
- user manually types in the value: in this case, user needs to configure the right unit first before typing. Or user needs to convert the value in mind if the selected unit is different from the one in user's mind (mostly the value is read from a catalog)
- user copies and pasts a value from a catalog: in this case, users need to configure the right unit first before pasting. If pasting happens first and changing the unit later, the value will be changed too.
In both cases. the new feature (synchronize the value and unit) does not help the UX and sometimes hurts. I suggest we keep the original way (desynchronize the value and unit)
Okay.
update:
Pending for https://github.com/CARTAvis/carta-backend/pull/1387 code review.
Description
This closed #2396 together with backend PR and its companion protobuf. This PR adds the rest frequency GUI to the moment generator.
Checklist
For linked issues (if there are):
For the pull request:
For dependencies:
BackendService
changed) / no ICD test fix needed (BackendService
unchanged)