CBIIT / crdc-datahub-cli-uploader

CRDC datahub data uploader is a command line interface for end users to upload cancer research files and metadata to Datahub.
1 stars 2 forks source link

Updated based on review. #1

Closed vshand11 closed 1 year ago

vshand11 commented 1 year ago

Hi Ming, I updated based on most of your review except "I suggest use argparse.FileType for argument —manifest and --config, which will take care of detecting file existence and permission etc."

The filetype is not only for validate the file path but also, read file content to _io.TextIOWrapper. Tried yaml.dump but not work. Since user could use config file only, we still need to validate and load the manifest file. We have no gain for such change. We may use it later in some pure arg app.