CBugDCoder / deltaglider

Add realistic hang gliders to Minetest
Other
4 stars 8 forks source link

General overhaul #11

Closed SwissalpS closed 4 days ago

SwissalpS commented 5 months ago

-Patches various bugs -Adds coloured gliders -More settings -FLAK support -Hook for other mods to influence flight-permissions -New textures to easily differentiate from [hangglider] -Adds sounds -Glider can be made to wear-out from damage and usages -Adds HUD for basic pilot instrument flight -Support for Mineclone -And more....

closes #4 closes #6 closes #7

Maverick2797 commented 5 months ago

Love the work. Some small things I've noticed with the hud:

Possibly some less-small things related to the physics:

SwissalpS commented 5 months ago

Many thanks for the valuable feedback.

  • The hud seems to "jitter" when rotating due to the decimals disappearing when the angle is a whole number. Is it possible to pad the value with a trailing zero to minimise this?

Yes, simple enough to do. I actually had it without decimals and only added them for debugging. Minetest isn't designed to be a flightsim and the HUD is just to help out a little. I don't think players need decimals in the heading indicator. A compass in the hotbar should be just fine.

  • "vV" and "v" seem arbitrary unless you understand that they're "Vertical Velocity" and "(Horizontal) Velocity" respectively. Maybe "Climb Rate" and "Airspeed" instead?

Yes, kindof. Both values are quite arbitrary but do help pilots understand why their glider is behaving the way it does. (v is actually speed factor multiplied to all directions). Your suggested labels are correct. I didn't use them because the first complaint from players is: "Ugh, the HUD is covering my view". Also translations in mind, I tried to go for some ISO standard short labels. Players with small screens quickly have overflows. Possibly a solution would be to add a chatcommand to toggle HUD and provide options on verbosity. (Originally I had vV only as +, - or =)

  • Perhaps a label on the rocket cooldown? It's currently just an unexplained countdown

Yeah, I was thinking of a coloured horizontal bar and that players would notice soon enough what it meant. I'll consider it again.

Possibly some less-small things related to the physics:

Disclaimer: I didn't change anything on the physics.

  • Opening the glider at high velocity (only tested by freefalling so far) can sometimes cause instant death

Seems reasonable to me. Something similar would happen if one found a way to do that IRL :D This mod is not the [hangglider] mod which is designed to break falls while this mod is a delta glider (I really want to rename this mod to that). Delta gliders are not safety devices, rather lightweight fixed wing aircraft.

  • If the player is killed by overspeed (ie freefalling then opens the glider as above) the player is sometimes also damaged when they respawn

That isn't unique to this mod. It happens on occasion with various mods. I'll call it an engine issue.

  • The glider can still climb higher than its initial launch altitude without using rockets after barely falling off a high enough cliff (ie without jumping, running or even walking.) Maybe some sort of climb-to-drag ratio to minimise this? Or just chalk it up to a good pilot being able to find lift? idk

I am unable to reproduce that (starting without moving). Maybe my hardware is too sluggish and old. With a running start, I can rise higher and I did consider that a good thing. It keeps the gap between [hangglider] and [(delta)glider] wide enough for servers to consider using both. Also it motivates players to use this glider at all, it's hard enough to even land safely. This mod is quite dangerous as it is, I consider it a good feature that one can actually gain altitude if one is skilled enough.

SwissalpS commented 5 months ago

Looking at heading more closely I noticed that flying in counterclockwise circles it is accurate. However flying in clockwise circles it becomes negative!

I'm torn between dropping heading information and fixing it. It's the least important of all the HUD info and was added more as a gimmick.

CBugDCoder commented 6 days ago

@SwissalpS Thank you so much for all the work that you have put into this. I have been busy with college so have stepped back from the Minetest community for the past couple years. I am glad to see my mod getting some love and a fresh life. After I playtest your patch, I will merge it into the main repository. I like the name Delta Gliders I think renaming the actual mod will be more complicated than desired and will break alot of worlds. Therefore, I will rename the ContentDB page to Delta Gliders and call it even.

SwissalpS commented 5 days ago

It has been a while, I don't remember if I added everything to this branch. Maybe just for good measure, you'll compare to my master branch to see if anything other than the rename has changed there. https://github.com/SwissalpS/minetest_deltaglider/tree/master

SwissalpS commented 5 days ago

(I'm glad you like the changes and I'm especially glad that you are back :D I was about to look for someone to maintain this.)

CBugDCoder commented 5 days ago

You did add a couple more things to the master branch, namely translations. If you could add all the changes you made to the master branch to the main repo, then I will merge the request. Include the full rename of the mod. I will figure out how to rename the mod on Content DB after the PR is merged. I also added you as a collaborator on this repository. I do not have time to maintain it and do not foresee myself getting back into the MT modding community anytime in the near future.

SwissalpS commented 5 days ago

If you could add all the changes you made to the master branch to the main repo, then I will merge the request. Include the full rename of the mod.

In that case it would be easiest for me to PR the master/main branch of my fork.

I do not have time to maintain it and do not foresee myself getting back into the MT modding community anytime in the near future.

Then we had better ask an org like https://github.com/mt-mods to adopt it.

CBugDCoder commented 4 days ago

Then we had better ask an org like https://github.com/mt-mods to adopt it.

You are more than welcome to do that. I enjoyed building mods and being in the MT community while I was in High Schoo, but that time is past. With this total overhaul, glider is as much your mod as it is mine now. If you do not want to be the primary maintainer of it, Feel free to find someone who will.

SwissalpS commented 4 days ago

@CBugDCoder I don't have permission to rename the repo, that'll be something you need to do.

CBugDCoder commented 2 days ago

It has been renamed. Thank you for everything!