ljmcgann commented 5 years ago

Updated the object models and corresponding business layer classes to include a project_id field tht will ultimately be used to determine ownership of objects. TG-163

codecov-io commented 5 years ago

Codecov Report

Merging #100 into master will decrease coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   91.76%   91.74%   -0.03%     
==========================================
  Files          45       45              
  Lines        1385     1381       -4     
==========================================
- Hits         1271     1267       -4     
  Misses        114      114

Impacted Files	Coverage Δ
flocx_market/tests/unit/objects/test_object_bid.py	`100% <ø> (ø)`	:arrow_up:
...ocx_market/tests/unit/objects/test_object_offer.py	`100% <ø> (ø)`	:arrow_up:
flocx_market/tests/unit/api/test_app_bid.py	`100% <ø> (ø)`	:arrow_up:
flocx_market/objects/contract.py	`95.45% <ø> (ø)`	:arrow_up:
flocx_market/tests/unit/api/test_app_offer.py	`100% <ø> (ø)`	:arrow_up:
flocx_market/tests/unit/api/test_app_contract.py	`100% <ø> (ø)`	:arrow_up:
flocx_market/objects/offer.py	`96.96% <ø> (ø)`	:arrow_up:
flocx_market/objects/bid.py	`96.96% <ø> (ø)`	:arrow_up:
flocx_market/tests/unit/db/sqlalchemy/test_api.py	`100% <ø> (ø)`	:arrow_up:
..._market/tests/unit/objects/test_object_contract.py	`100% <ø> (ø)`	:arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be1411c...5f3d0ac. Read the comment docs.

tzumainn commented 5 years ago

It looks like we need one more change: remove creator_id from all the database models (and object fields, and tests, etc).

tzumainn commented 5 years ago

Looks good!

CCI-MOC / flocx-market

Updated models with project_id #100

Codecov Report