search

CCI-MOC / flocx-market

2 stars 9 forks source link

expire offer_contract relationship when offers/contracts expired #140

Closed DanNiESh closed 5 years ago

DanNiESh commented 5 years ago

fix #123

codecov-io commented 5 years ago

Codecov Report

Merging #140 into master will decrease coverage by 0.43%. The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage    92.9%   92.47%   -0.44%     
==========================================
  Files          52       52              
  Lines        2114     2125      +11     
==========================================
+ Hits         1964     1965       +1     
- Misses        150      160      +10
Impacted Files Coverage Δ
flocx_market/manager/service.py 64.28% <9.09%> (-10.3%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 736af76...cf36aa2. Read the comment docs.

larsks commented 5 years ago

Looks good, but needs to be rebased on current master.

DanNiESh commented 5 years ago

I think this is close! Just a small issue in retrieving all the ocrs

Also, I wouldn't use the abbreviation 'cors' over 'ocrs'

Hi Mainn! Sorry for the late reply. My university email account has some issue so that I just checked the emails from the last 5 days and just got the message from flocx github. I've made the changes according to your suggestions. Thanks!

tzumainn commented 5 years ago

Not at all - I appreciate you coming back and updating the PR!