Matcher API & Tests - Githubissues

CCI-MOC / flocx-market

2 stars 9 forks source link

Matcher API & Tests #24

Closed aliraza0337 closed 5 years ago

aliraza0337 commented 5 years ago

This PR implements the python API that takes a list of criteria and ironic configurations and returns True or False depending on if the criteria is met by the ironic configurations. It also includes the tests for the matcher code.

tzumainn commented 5 years ago

It may be worth updating the commit message, specifically the title?

larsks commented 5 years ago

@tzumainn I thought the description was pretty good. I guess maybe the subject line could use a minor update.

tzumainn commented 5 years ago

Yeah, the subject is what I meant.

larsks commented 5 years ago

@aliraza0337 did you see Mainn's comment?

aliraza0337 commented 5 years ago

Yes, let me update.

tzumainn commented 5 years ago

Looks good, nice job!