Closed DanNiESh closed 5 years ago
Hi! This is looking good. I'm going to have a few random comments:
git rebase
rather than git pull
. The latter creates merge commits, while the former will re-apply your branch commits on top of any changes that might have happened on master.I know this can be confusing, so if you want to walk through this stuff together sometime, just let me know!
@tzumainn @DanNiESh if you haven't seen them already, I wrote up this article on making good pull requests and commit messages, and this one about squashing together a troublesome pr.
Overall, I think the code looks good! I would encourage you to separate out the commits into smaller bits of work. Separating out the .gitignore commit is good; I'd go further by making separate commits for:
conf/
api/
to use the conf parametersAnd other small, discrete updates that make sense by themselves.
I followed the suggestion from Mainn and implemented the common service code. This pull request does not show the work on database models. I imitated esi-leap code, created config files in conf folder, created service.py in common folder and also changed some files in api folder. Now we can run the project with "sudo flocx-market-api", which is the entrypoint flocx_market.cmd.api:main (hopefully, if the pythonpath is correct) I have some problems though: