search

CCI-MOC / flocx-market

2 stars 9 forks source link

Fixed up flake8 errors and create_invalid test for the offer API #70

Closed fvukelic closed 5 years ago

fvukelic commented 5 years ago

Fixed up flake8 errors in in tests/unit/common/test_service.py. Fixed up test_offer_api: changed the order of data in data creation and test_create_invalid.py

codecov-io commented 5 years ago

Codecov Report

Merging #70 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   90.28%   90.23%   -0.06%     
==========================================
  Files          27       26       -1     
  Lines         556      553       -3     
==========================================
- Hits          502      499       -3     
  Misses         54       54
Impacted Files Coverage Δ
..._market/tests/unit/db/sqlalchemy/test_offer_api.py 100% <ø> (ø) :arrow_up:
flocx_market/tests/unit/common/test_service.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e32177c...a23bba6. Read the comment docs.

fvukelic commented 5 years ago

@larsks really simple PR, just moved out the stuff from the Bid PR that you requested, as soon as this one is merged, I have the Bid rebased on top so I will be submitting the updated PR for that as well.