search

CCI-MOC / flocx-market

2 stars 9 forks source link

Update sqlalchemy code to use oslo db libraries #77

Closed tzumainn closed 5 years ago

tzumainn commented 5 years ago

This change updates sqlalchemy code to use oslo db libraries for models and for sessions.

Addresses #54

tzumainn commented 5 years ago

The bid api merged while I was working on this, and the bid tests will fail if the bid database code is not updated to match the changes here; so I included a commit for updating the bid code as well.

codecov-io commented 5 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.84%. The diff coverage is 98.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #77      +/-   ##
=========================================
+ Coverage   91.95%   92.8%   +0.84%     
=========================================
  Files          31      28       -3     
  Lines         721     750      +29     
=========================================
+ Hits          663     696      +33     
+ Misses         58      54       -4
Impacted Files Coverage Δ
flocx_market/cmd/dbsync.py 0% <0%> (ø) :arrow_up:
flocx_market/tests/unit/conftest.py 100% <100%> (ø) :arrow_up:
flocx_market/tests/unit/api/test_app_bid.py 100% <100%> (ø) :arrow_up:
flocx_market/db/sqlalchemy/models.py 100% <100%> (ø) :arrow_up:
flocx_market/api/bid.py 100% <100%> (ø) :arrow_up:
flocx_market/tests/unit/db/sqlalchemy/test_api.py 100% <100%> (ø) :arrow_up:
flocx_market/api/offer.py 100% <100%> (ø) :arrow_up:
flocx_market/db/sqlalchemy/api.py 98.38% <98%> (+2.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6a6f30...936fdd5. Read the comment docs.

larsks commented 5 years ago

It looks like our tests are never calling offer_get_all, bid_get_all, or bid_update: https://codecov.io/gh/CCI-MOC/flocx-market/pull/77/src/flocx_market/db/sqlalchemy/api.py?before=flocx_market/db/sqlalchemy/api.py

tzumainn commented 5 years ago

It looks like our tests are never calling offer_get_all, bid_get_all, or bid_update: https://codecov.io/gh/CCI-MOC/flocx-market/pull/77/src/flocx_market/db/sqlalchemy/api.py?before=flocx_market/db/sqlalchemy/api.py

I've added tests for these