search

CCI-MOC / flocx-market

2 stars 9 forks source link

Update business object save code to use oslo versionedobject code #90

Closed tzumainn closed 5 years ago

tzumainn commented 5 years ago

By using oslo versioned object code, we can call save without passing in a dict. Instead, we can just modify the object fields before calling save().

Addresses #89

codecov-io commented 5 years ago

Codecov Report

Merging #90 into master will decrease coverage by 0.17%. The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   97.35%   97.18%   -0.18%     
==========================================
  Files          35       35              
  Lines         909      924      +15     
==========================================
+ Hits          885      898      +13     
- Misses         24       26       +2
Impacted Files Coverage Δ
flocx_market/tests/unit/objects/test_object_bid.py 100% <100%> (ø) :arrow_up:
...ocx_market/tests/unit/objects/test_object_offer.py 100% <100%> (ø) :arrow_up:
flocx_market/objects/bid.py 96.29% <100%> (-3.71%) :arrow_down:
flocx_market/tests/unit/api/test_app_bid.py 100% <100%> (ø) :arrow_up:
flocx_market/tests/unit/api/test_app_offer.py 100% <100%> (ø) :arrow_up:
flocx_market/objects/offer.py 96.29% <100%> (-3.71%) :arrow_down:
flocx_market/api/bid.py 96.66% <75%> (-3.34%) :arrow_down:
flocx_market/api/offer.py 96.66% <75%> (-3.34%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 500c192...6b769be. Read the comment docs.