search

CCI-MOC / hil

Hardware Isolation Layer, formerly Hardware as a Service
Apache License 2.0
24 stars 54 forks source link

Flask-Script is Deprecated #984

Open xuhang57 opened 6 years ago

xuhang57 commented 6 years ago

https://github.com/smurfix/flask-script And as mentioned here: https://github.com/CCI-MOC/hil/issues/975 we need to figure out how to deal with Flask-Migrate

screen shot 2018-03-22 at 12 54 14
xuhang57 commented 6 years ago

I believe you can use the flask CLI with Flask-Migrate as well: https://flask-migrate.readthedocs.io/en/latest/

Not sure how to handle this yet. Maybe rather than:

hil-admin db create which is essentially: cread_db() in hil.migrations Should we do flask db init?

So, the question is, should we keep using flask-script so we can build a cli such as hil-admin or we should use flask cli instead.

zenhack commented 6 years ago

The flask command is just a wrapper on top of click. It would be nice to integrate hil-admin with that since we're using click for the hil command anyway.

It might be nice to keep a thin wrapper around it, just to set up a few things automatically and be a bit more intuitive to sysadmins who are not also python developers; I don't like to expose too much internal tooling goop.