CCMS-UCSD / GNPS_Workflows

Public Workflows at GNPS
https://gnps.ucsd.edu/
Other
51 stars 43 forks source link

IIMN with OpenMS #834

Closed eeko-kon closed 2 years ago

eeko-kon commented 2 years ago

Describe the bug

The network is collapsing, but the edges in a non-collapsed view are all the same. I should be able to see "cosine score" and "MS1 annotation" under "Style" - "Edges" - "EdgeType", only the option of "cosine score" is passed/offered. Meaning that the MS1 annotation under EdgeType information (SuppPairs.csv) is not passed for some reason.

To Reproduce

Steps/Task to reproduce the behavior:

  1. Go to 'https://gnps.ucsd.edu/ProteoSAFe/status.jsp?task=c442343427c24c20bcf24e8199440f25'
  2. Files used https://drive.google.com/drive/folders/1vPgj6iaIavfejLIoat1_a8PzqYlSykZK?usp=sharing
mwang87 commented 2 years ago

Can you run this on P2?

eeko-kon commented 2 years ago

It's from P2, I just accessed it from the main GNPS page now. Here is from P2:

https://proteomics2.ucsd.edu/ProteoSAFe/status.jsp?task=c442343427c24c20bcf24e8199440f25

eeko-kon commented 2 years ago

@mwang87 I was supposed to come to the office hours but never made it this week. Did you have time to look into that ? Thanks a lot!

mwang87 commented 2 years ago

@robinschmid do you think the existing code for collapsing should have handled this for IIMN?

eeko-kon commented 2 years ago

Still nothing @mwang87 https://proteomics2.ucsd.edu/ProteoSAFe/status.jsp?task=95841335101b42adbacdbe330e98baa3

mwang87 commented 2 years ago

I found another bug, testing again.

On Tue, Apr 26, 2022 at 11:06 AM Efi Kontou @.***> wrote:

Still nothing @mwang87 https://github.com/mwang87

https://proteomics2.ucsd.edu/ProteoSAFe/status.jsp?task=95841335101b42adbacdbe330e98baa3

— Reply to this email directly, view it on GitHub https://github.com/CCMS-UCSD/GNPS_Workflows/issues/834#issuecomment-1110098538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXSEBWP5OLRSNODJGQUKDVHAWA5ANCNFSM5R3HYZ7Q . You are receiving this because you were mentioned.Message ID: @.***>

eeko-kon commented 2 years ago

Problem fixed!