Closed katyasoup closed 3 weeks ago
Thanks @katyasoup ! This looks great. Could you please make these changes?
I was trying to review the error state, and it seems like I am able to log in with any credential. Is that just because it doesn't work yet?
Is that what this means?
Redirect to /query from Sign In page on button click (regardless of form data)
Also, log out takes me to 404. Also not sure if that's intentional.
Thanks @katyasoup ! This looks great. Could you please make these changes?
- Remove the lefthand blue image at the 768px breakpoint
- Stack the footer text on two lines at the 960px breakpoint (right now, they overlap)
I was trying to review the error state, and it seems like I am able to log in with any credential. Is that just because it doesn't work yet?
Is that what this means?
Redirect to /query from Sign In page on button click (regardless of form data)
Also, log out takes me to 404. Also not sure if that's intentional.
@mikang thanks! I'll add in the error state styles (but you are correct, that line about redirecting to /query just means any (or no) credential will work).
For the breakpoints - happy to add those here, though I wonder if it's worth capturing it in a new ticket? There are other areas that could use some adjustment as well to be more responsive. Can bring this up at standup, too :)
Awesome @katyasoup !!! The responsiveness is great, and I also see the error states.
Could you please make these changes?
Could you also please change the font? This is my fault — I didn't update the designs, sorry! I believe @fzhao99 may have already standardized this in your design system. I've updated the Figma file accordingly.
So it should look like this now:
Thank you!!
Could you also please change the font? This is my fault — I didn't update the designs, sorry! I believe @fzhao99 may have already standardized this in your design system. I've updated the Figma file accordingly.
I can handle this piece once this PR goes in! We might even get it for free because of the way the styles are tokenized
Woohoo!!! Awesome, thank you @fzhao99 !!!
PULL REQUEST
Summary
Related Issue
Fixes #77
Acceptance Criteria
GIVEN the Query Connector landing page WHEN a user clicks "Sign In" THEN they are redirected to the /signin page
GIVEN the Query Connector /signin page WHEN a user clicks Sign In THEN they are redirected to /query
Note for designers: The data usage policy button wasn't included in the Figma mockup; happy to adjust its placement as needed/desired!
Additional Information
Checklist