search

CDCgov / dibbs-query-connector

A FHIR client allowing public health agencies to query health care organizations directly or via a TEFCA QHIN
Creative Commons Zero v1.0 Universal
4 stars 0 forks source link

Allow overwriting inserts #91

Closed bamader closed 3 weeks ago

bamader commented 3 weeks ago

Allow overwriting inserts

Summary

This PR modifies the INSERT statement of our InsertValueSet function to allow for duplicated uniqueIDs to overwrite those of existing entries. Our DB creation process will go through a fair number of duplicate value sets after pulling down the eRSD, so simply overwriting them with the same data will allow the seeding process to proceed more smoothly than error-ing and breaking the transaction.

Related Issue

Fixes #81

Additional Information

I created a test branch here https://github.com/CDCgov/dibbs-query-connector/tree/test-vs-overwrite that removes database seeding in migrations 2 through 6, and instead adds a button to the landing page that tests a couple cases of inserting valuesets and duplicates into the DB. No errors get thrown and viewing the DB in DBeaver shows all rows correctly entered.

bamader commented 3 weeks ago

Adding Dan as a reviewer to get any thoughts