CDCgov / phdi

https://cdcgov.github.io/dibbs-site/
Creative Commons Zero v1.0 Universal
35 stars 14 forks source link

ecr library search by name #2821

Closed BobanL closed 1 month ago

BobanL commented 1 month ago

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

Fixes #2602

Acceptance Criteria

NOT an acceptance criteria: we're just doing strict search at this point, not fuzzy matching. If I search "Jon", I'm not going to see any patients named "John" (note different spelling).

Additional Information

image image https://github.com/user-attachments/assets/d958364f-06fc-40dd-947c-8a274052efc1

Checklist

BobanL commented 1 month ago

Ready for design review @ashton-skylight!

ashton-skylight commented 1 month ago

Looks great! Thanks @bobanl

gordonfarrell commented 1 month ago

The one funky thing with it right now is that there's no way to get back from your search to the full list without refreshing the page or re-searching with an empty string. Is that going to be covered by the clear filters button that I think is coming in another ticket?