CDCgov / trusted-intermediary

Bringing together healthcare providers by reducing the connection burden.

Apache License 2.0

11 stars 5 forks source link

Rename reportId variables #1601

Open pluckyswan opened 1 week ago

pluckyswan commented 1 week ago

Description

Rename variables, like (sent/received)SubmissionId and (sent/received)MessageId to be (inbound/outbound)ReportId, and any related functions. The naming, inbound and outbound, is from the perspective of TI. The id that we were receiving from ReportStream is now the inbound id while the id we were sending to ReportStream is now the outbound id.

Issue

https://github.com/CDCgov/trusted-intermediary/issues/1404

Checklist

[ ] I have added tests to cover my changes
[ ] I have added logging where useful (with appropriate log level)
[ ] I have added JavaDocs where required
[ ] I have updated the documentation accordingly

Note: You may remove items that are not applicable

github-actions[bot] commented 1 week ago

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Consistency Check
Ensure that the renaming of variables from 'receivedSubmissionId' to 'inboundReportId' maintains consistency across all related methods and classes, especially where method signatures and return types might be affected.

github-actions[bot] commented 1 week ago