search

CDRH / api

Codenamed "Apium": An API to access all public Center for Digital Research in the Humanities resources
https://cdrhdev1.unl.edu/api_frontend
MIT License
3 stars 1 forks source link

add ability to change class on <html> element #50

Closed jduss4 closed 7 years ago

jduss4 commented 7 years ago

pages should know their identity and be able to pass controller variable to set class so Karin can use one stylesheet

jduss4 commented 7 years ago

I recall this was trouble with turbolinks or some other rails caching type of mechanism, specifically with the neihardt version of the site, but I have no idea if Rails 5 can handle it or if other things have changed about how the pages are rendered which would mean this works out better. Should revisit.

Example: https://github.com/CDRH/neihardt/blob/master/app/views/layouts/application.html.erb#L2

karindalziel commented 7 years ago

Debating on whether this should always be explicitly set (i.e. passing through a variable from the view) OR if it should be entirely based on the URL. In cocoon I mostly depended on routes/url's. I'd set the home page explicitly: 

<html class="home">

and then all the other pages I'd set by the first part of the URL:

www.whatever.org/*/**/***.html
* above = the text that gets inserted as a class name

To be more future proof, we may want to prepend something to make sure that class names don't collide with any framework classes. so maybe

site_home
site_about
site_writings

etc.

Thoughts?

karindalziel commented 7 years ago

We had a brief discussion about the feasibility of including this based on the url - for most sites, I think this would be enough, though being able to overwrite from a view would also certainly be useful.

techgique commented 7 years ago

Another option may be to use the controller name, params[:controller], similarly to how it is described here: http://edgeguides.rubyonrails.org/asset_pipeline.html#controller-specific-assets

jduss4 commented 7 years ago

I vaguely recall trying to use the controller previously for the Neihardt test run and it didn't have as fine of control as Karin was looking for. Maybe controller + action?

jduss4 commented 7 years ago

Closing this because I opened it on the orchid repository at https://github.com/CDRH/orchid/issues/15