search

CEMPD / SMOKE

Create emissions inputs for multiple air quality modeling systems with unmatched speed and flexibility
https://www.cmascenter.org/smoke/
49 stars 22 forks source link

Making Movesmrg to apply adjustment factors by state #104

Closed hnqtran closed 2 weeks ago

hnqtran commented 4 months ago

Issue reported by Alison: Right now Movesmerge only applies adjustment factor by county and couldn’t make use of the month-specific factors.

callen52 commented 4 months ago

Modifying this description somewhat - what we would like to be able to do is apply adjustment factors by state, e.g. list FIPS 08000 in the CFPRO and have those adjustments apply to all of Colorado. As it stands now, in cases where adjustment factors vary by state, instead of listing state FIPS in the CFPRO, we have to list every county individually in the CFPRO, or every representative county individually (with USE_REF_CONTROL_FAC_YN = Y), in order to apply a set of state-level factors. Since Movesmrg run time depends on the size and complexity of the CFPRO file, run time with a county-level CFPRO is significantly longer than run time with a state-level CFPRO would be.

Related to this, I recently discovered a bug when applying adjustment factors by representative county (USE_REF_CONTROL_FAC_YN = Y) in Movesmrg. If there is a group in which a rep county is mapped to several counties, where the rep county itself has no activity (which can happen with hoteling / RPH in particular) but other counties in the rep county group do have activity, then the adjustments are not applied to the other counties in the rep county group.

I can provide a test case if needed down the road (assuming you wouldn't get to this until September or later), but I'd say that adding capability to Movesmrg to apply factors by state is higher priority than fixing the USE_REF_CONTROL_FAC_YN bug.

hnqtran commented 4 months ago

Created a separate ticket for the USE_REF_CONTROL_FAC_YN bug.

@callen52, thanks for providing details on the issues. When it is possible, please provide test case for the USE_REF_CONTROL_FAC_YN bug as well as for the case where you had to do by-county adjustment to get around the by-state adjustment.

bokhaeng commented 1 month ago

@callen52 When the state-level CFPRO is enabled, I tihnk the USE_REF_CONTROL_FAC_YN should be disabled. So then state-level control factor should be applied to all counties within the state whether they are reference counties or not. If there is a reference county-specific control factor within the state, then it can overwrite the state-level control factors with the one from the reference county. Do you see any other cases that I need to consider in this update?

callen52 commented 1 month ago

@bokhaeng Makes sense to me. I don't think a situation has come up so far where we would need to have a combination of both state-level and rep-county-level factors in the same run.

bokhaeng commented 2 weeks ago

Enabled Movesmrg to apply the state-level CFPRO. Confirmed that the update is working correctly. However, #105 related to RPH CFPRO bug is still opened.