search

CExA-project / ddc

DDC is a discrete domain computation library.
https://ddc.mdls.fr
Other
33 stars 5 forks source link

Corner case missing in cartesian_prod #669

Closed blegouix closed 2 weeks ago

blegouix commented 1 month ago

Hello,

I think the case:

template <>
struct cartesian_prod<>
{
    using type = ddc::DiscreteDomain<>;
};

Is missing at https://github.com/CExA-project/ddc/blob/806d786e877a15c92b66ffa0df5a0335766f5ab3/include/ddc/discrete_domain.hpp#L404

Also cartesian_prod is not tested.

tpadioleau commented 1 month ago

Yes that can be added