search

CGrassin / tinwhistletabs

Tin whistle tabs: listen and play hundreds of traditional tunes!
GNU General Public License v2.0
12 stars 3 forks source link

Sorting and filtering #1

Open dave-burke opened 8 months ago

dave-burke commented 8 months ago

Hi! I see on the README that you would like to have sorting and filtering of songs. Would you be open to a PR for this? I'm a Java developer professionally. I have never worked on an Android app, but am looking for an excuse to learn.

If you are open to PRs, let me know if you want it done a certain way (implementation or user interface).

Either way, thanks for a great app! I really like it.

CGrassin commented 8 months ago

Hi Dave!

Thank you for you interest in the project! Of course, your contribution would be appreciated!

The implementation of such a feature is quite simple: in fact, it is already kind of included in the codebase, because it is the same thing as the search. However, the reason I have not added it is that I don't really know how to handle the UI/UX aspect in a way that makes sense. You are more that welcome to propose something!

To be fully honest, although it is originally a user requested feature, I don't fully see the point of having filters. However, a very similar feature that was also requested is to add favorites, which I have an easier time seeing the benefit of.

Thanks again, Charles