CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

Add a warning if SUMMA performs a relative humidity correction? #507

Open wknoben opened 2 years ago

wknoben commented 2 years ago

Feature Requests

https://github.com/CH-Earth/summa/blob/fa9adf808229a45085defdc2bb8ef05836b9b3aa/build/source/engine/derivforce.f90#L276-L282

Might be helpful to users if this correction also prints a warning, so that it becomes easier to track what happens to the provided forcing data

andywood commented 2 years ago

I support adding a warning if it can be included under a --verbose option for output. Even in that case, it might be good to restrict or summarize it in some way so that it doesn't have the potential to print every timestep and every hru, which would be unnecessary. Perhaps create an end-of-run warning message listing the first 10 occurrences (hru, date, values).

SUMMA could even write such warnings to a file rather than merge them with screen output -- such as the 'runinfo' file which is created at the start to make sure the output directory exists. Rather than close that file, use it to collect certain types of warnings that a user could see if they wanted to.