search

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

add depth dimension to soil variables #513

Closed martynpclark closed 1 year ago

martynpclark commented 2 years ago

Make sure all the relevant boxes are checked (and only check the box if you actually completed the step):

Added depth dimension to soil parameters. Andrew Ireson -- can you run with your test cases and check this works for you?

andywood commented 1 year ago

Just to check, is this backward compatible so that old parameter files still run?

On Wed, Jul 6, 2022 at 2:54 PM Martyn Clark @.***> wrote:

Make sure all the relevant boxes are checked (and only check the box if you actually completed the step):

  • Closes #xxx (identify the issue associated with this PR)
  • Code passes standard test cases (results are either bit-for-bit identical, or differences are explained in the PR comment)
  • New tests added (describe which tests were performed to test the changes)
  • Science test figures (add figures to PR comment and describe the tests)
  • Checked that the new code conforms to the SUMMA coding conventions https://github.com/NCAR/summa/blob/master/docs/howto/summa_coding_conventions.md
  • Describe the change in the release notes (use either ./summa/docs/whats-new.md or ./summa/docs/minor-changes.md depending on what changed)

Added depth dimension to soil parameters. Andrew Ireson -- can you run with your test cases and check this works for you?

You can view, comment on, or merge this pull request online at:

https://github.com/CH-Earth/summa/pull/513 Commit Summary

File Changes

(4 files https://github.com/CH-Earth/summa/pull/513/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/CH-Earth/summa/pull/513, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARLSWSYYDCQQCFITQCLVSXXA3ANCNFSM523DQ43A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

martynpclark commented 1 year ago

Yes, all is backward compatible. If the parameter is a scalar variable then it is automatically copied to all layers.