search

CHLNDDEV / OceanMesh2D

A two-dimensional triangular mesh generator with pre- and post-processing utilities written in pure MATLAB (no toolboxes required) designed specifically to build models that solve shallow-water equations or wave equations in a coastal environment (ADCIRC, FVCOM, WaveWatch3, SWAN, SCHISM, Telemac, etc.).
https://github.com/sponsors/krober10nd
GNU General Public License v3.0
178 stars 64 forks source link

Multiple changes after throughout testing #308

Closed omouraenko closed 4 months ago

omouraenko commented 4 months ago

Changes include:

  1. Ran core functions through MATLAB's auto indent (ctrl-i) to make code more readable. Please review the changes with "Ignore whitespace" diff settings.
  2. Renamed multiple functions, which are also available in OpenEarthTools but different.
  3. Reworked 'setup' functions.
  4. Reworked 'Examples' functions and added necessary files. The idea is to separate examples from the core functions.
  5. Multiple small bug fixes.

Thank you.

krober10nd commented 4 months ago

Thanks very much @omouraenko

@WPringle lets merge this into #264 and then resolve any conflicts there?

omouraenko commented 4 months ago

BTW, in case someone does not know, when checking "Files changed", one can add "?w=1" to the URL to omit differences in whitespaces. This option is also available under Settings (gear icon).

WPringle commented 4 months ago

Thanks very much @omouraenko

@WPringle lets merge this into #264 and then resolve any conflicts there?

I'm not sure which is better, but it may be fine to leave here, but just need to decide which one to pull into projection first. If we do this first then it would be equivalent to your suggestion I think.