CHOP-CGTInformatics / REDCapTidieR

Makes it easy to read REDCap Projects into R
https://chop-cgtinformatics.github.io/REDCapTidieR/
Other
33 stars 8 forks source link

JOSS Feedback Round 1 #170

Closed rsh52 closed 9 months ago

rsh52 commented 9 months ago

Description

This PR addresses requests from the first round of reviewer feedback:

The original paper word count according to the JOSS bot was 1189 words (limit in the criteria is supposed to be 1000), and this adds even more. If there's any feedback on things to remove, happy to implement.

This PR closes #168 and closes #167

rsh52 commented 9 months ago

For the time being placed the failing snapshot test in a skip_on_ci() so this doesn't block JOSS review. We can fix the test with a similar approach to the CGTTrialsReporter at a later point.

@spgarbet I believe you already "approved" on the review page, but tagging you for awareness as well.