CICE-Consortium / CICE

Development repository for the CICE sea-ice model
Other
57 stars 131 forks source link

Add vorticity as a diagnostic output #924

Closed JFLemieux73 closed 8 months ago

JFLemieux73 commented 9 months ago

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

385 measured results of 385 total results 385 of 385 tests PASSED 0 of 385 tests PENDING 0 of 385 tests MISSING data 0 of 385 tests FAILED

JFLemieux73 commented 9 months ago

Because of the different location of u and v, the calculation of vorticity for the B and C grids are not exactly the same. The vorticity fields are however similar. Here is an example for the B-grid:

B_vort_2005-01-02-00000

and the C-grid: C_vort_2005-01-02-00000

JFLemieux73 commented 9 months ago

I forgot to mention that I am adding vorticity as an output in order to use Nils Hutter's linear kinematic features (LKFs) detection algorithm. Nils' tool uses vorticity to identify conjugate fault lines.

apcraig commented 9 months ago

I will test this on derecho when it's ready. I can run the full io_suite which will cover binary, netcdf, and pio options. Please let me know when you'd like me to do that.

JFLemieux73 commented 9 months ago

Hi @apcraig,

I added f_vort to the two set_nml files. Please go ahead with the testing.

JFLemieux73 commented 9 months ago

This does not add a lot of computations because it is done after the EVP subcycling loop. I would keep the computation of vorticity together with divergence and shear (as proposed in this PR). The shear strain rate invariant (a diagnostic) is currently calculated in the deformations subroutine. If we move the vorticity to ice_history.F90 then we should do the same for the shear. I suggest we keep both in the deformations subroutine. @eclare108213 what do you think about this?

apcraig commented 9 months ago

I ran a full test suite on derecho with intel, gnu, cray. Results look good. If things get updated again, I'm happy to retest.

JFLemieux73 commented 8 months ago

Can we merge this PR?

apcraig commented 8 months ago

I just resolved some conflicts with the last PR and will run a short test suite to confirm no problems. Once complete, I'll merge unless there is further discussion.

apcraig commented 8 months ago

I ran the quick_suite and io_suite on derecho with cray, gnu, intel. All tests pass bit-for-bit. Will merge now.