Closed JFLemieux73 closed 8 months ago
Because of the different location of u and v, the calculation of vorticity for the B and C grids are not exactly the same. The vorticity fields are however similar. Here is an example for the B-grid:
and the C-grid:
I forgot to mention that I am adding vorticity as an output in order to use Nils Hutter's linear kinematic features (LKFs) detection algorithm. Nils' tool uses vorticity to identify conjugate fault lines.
I will test this on derecho when it's ready. I can run the full io_suite which will cover binary, netcdf, and pio options. Please let me know when you'd like me to do that.
Hi @apcraig,
I added f_vort to the two set_nml files. Please go ahead with the testing.
This does not add a lot of computations because it is done after the EVP subcycling loop. I would keep the computation of vorticity together with divergence and shear (as proposed in this PR). The shear strain rate invariant (a diagnostic) is currently calculated in the deformations subroutine. If we move the vorticity to ice_history.F90 then we should do the same for the shear. I suggest we keep both in the deformations subroutine. @eclare108213 what do you think about this?
I ran a full test suite on derecho with intel, gnu, cray. Results look good. If things get updated again, I'm happy to retest.
Can we merge this PR?
I just resolved some conflicts with the last PR and will run a short test suite to confirm no problems. Once complete, I'll merge unless there is further discussion.
I ran the quick_suite and io_suite on derecho with cray, gnu, intel. All tests pass bit-for-bit. Will merge now.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
385 measured results of 385 total results 385 of 385 tests PASSED 0 of 385 tests PENDING 0 of 385 tests MISSING data 0 of 385 tests FAILED