CICE-Consortium / CICE

Development repository for the CICE sea-ice model
Other
53 stars 128 forks source link

Fix Github Actions for macos system update #948

Closed apcraig closed 2 months ago

apcraig commented 2 months ago

PR checklist

Github Actions broke again after default macos system update.

Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.

apcraig commented 2 months ago

It's not fixed yet, need to trigger github actions to debug. First mod was adding a trivial change to create the PR, still trying to figure out what's happening. Unfortunately, I need to debug in the PR.

eclare108213 commented 2 months ago

I see. Would it not work to PR into another branch of your own?

apcraig commented 2 months ago

True, I could test it in my fork first. That would require I explicitly turn on the github actions on that branch in my fork. Sort of easier just to do it in regular PR as long as others don't mind too much :)

apcraig commented 2 months ago

This is ready for merge.