FIRE-4508 - Portability, hardening and output

[nser77]

Hello, with this patch I solved the following issue raised by the community:

• In some distributions, sh is a link to bash; this introduces some portability problemas while processing the ${IPTABLES_OUTPUT_QUEUE} with echo; let's switch to printf.
• AddHP function was not removed from the parsing loop so it was not aligned with the module overall logic; let's increase the ${IPTABLES_OUTPUT_QUEUE} length from 4 to 6 to add hardening points and use them into the resume section.
• We were sorting the ${IPTABLES_OUTPUT_QUEUE} even if it's empty; let's add a condition to avoid that.

Thanks!

[mboelen]

Thanks, merged!

[teoberi]

Now lynis.log is more concise and clear.

2024-10-16 13:23:49 ==== 2024-10-16 13:23:49 Performing test ID FIRE-4508 (Check used policies of iptables chains) 2024-10-16 13:23:49 Info: sorting output 2024-10-16 13:23:49 Result: Found target 'ACCEPT' for chain 'INPUT' (table: filter) 2024-10-16 13:23:49 Hardening: assigned partial number of hardening points (1 of 3). Currently having 121 points (out of 177) 2024-10-16 13:23:49 Result: Found target 'DROP' for chain 'INPUT' (table: filter) 2024-10-16 13:23:49 Hardening: assigned maximum number of hardening points for this item (3). Currently having 124 points (out of 180) 2024-10-16 13:23:49 Info: sorting output 2024-10-16 13:23:49 Result: Found target 'ACCEPT' for chain 'INPUT' (table: security) 2024-10-16 13:23:49 Hardening: assigned partial number of hardening points (1 of 3). Currently having 121 points (out of 177) 2024-10-16 13:23:49 ====

[nser77]

Yes