search

CJTozer / SublimeDiffView

Side-by-Side Git, SVN and Bazaar Diff Viewer for Sublime Text 3
https://packagecontrol.io/packages/DiffView
MIT License
20 stars 7 forks source link

Preview not closed when starting in 2-column view #22

Open CJTozer opened 8 years ago

CJTozer commented 8 years ago

Put the editor in 2-column view, then try a diff.

After pressing esc to finish, the LHS preview is still there.

CJTozer commented 8 years ago

This is a bit tricky, as there doesn't seem to be any good way to work out if open_file is really creating a new file, or just focussing on an existing one.

In the latter case, if we blindly close the 'previews' then we could close a view that was genuinely there before the diff...

window.find_open_file() only returns one file, not the possible set (in different views).

CJTozer commented 8 years ago

Ok, I can't see a quick fix for this, so let's push out of v1.0.0. If there are people clamouring for this fix I'll revisit, otherwise just on the backlog.

Nikaoto commented 6 years ago

I submitted an issue, which is probably connected to this: https://github.com/CJTozer/SublimeDiffView/issues/55

I am demonstrating the problem with a two-column view, but even with a single-column view the diff previews are still not closing after pressing escape .

CJTozer commented 6 years ago

Thanks for the report - I'll try to take another look at this. Perhaps the ST3 APIs have improved, or I'll come up with a good enough workaround.