CLADevs / VanillaX

A plugin which adds Vanilla blocks, items, entities and more to your server.
81 stars 29 forks source link

inv crashed and get error packet #219

Closed TukangM closed 1 year ago

TukangM commented 1 year ago

https://github.com/pmmp/PocketMine-MP/issues/5398 moved to here

Issue description

Steps to reproduce the issue

1.i goto mine world and go to crafting table

  1. when i am ink crafting table i select stick item image and then woood acacia planks automaticly placed on crafting table image (imagine the wood placed on crafrting table )
  2. then me got kicked image
    [12:56:38.198] [Server thread/ERROR]: [NetworkSession: TrialShip171896] Bad packet (error ID bf46d50a7941): Error processing ItemStackRequestPacket: ItemStackRequestPacket: VarInt did not terminate after 5 bytes!
    [12:56:38.206] [Server thread/INFO]: TrialShip171896 left the game
    [12:56:38.216] [Server thread/INFO]: [NetworkSession: TrialShip171896] Session closed due to Packet processing error (Error ID: bf46d50a7941)
    [12:56:38.218] [RakLib thread/NOTICE]: Blocked fe80::131:62d4:703:e93e for 5 seconds
    [12:56:38.655] [Server thread/INFO]: Unloading world "mine"

OS and versions

Plugins

AntiInstaBreak v1.0.0, AutoDisableWorlds v1.0.0, BasicScore v1.2.2, BedrockEconomy v2.0.8, BetterWarps v1.0.0, BlockLagFix v1.7.0, ChestShop v5.3.5, ClearLag v2.1.0, CustomJoinSound v1.0.3, DevTools v1.16.0, DeviceACM v2.0.0, Disguise v1.0.0, EasyCommandAutofill v3.0.2, EasyEdit v2.1.1, EconomyEnchant v1.0.3, Freedom v1.0.0, GetPing v0.1.0, InvCrashFix v0.0.1, InvSee v2.2.3, KeepExp v0.0.1, KeepInventory v2.1.4, MaxEnchants v1.2.4, MultiProtocol v1.0.0-API4beta, MultiWorld v2.0.0-beta1, Netherite v2.3, OpList v2.0.2, PiggyCrates v3.0.3, PiggyCustomEnchants v3.0.8, PlayerSelectors v2.0.0, PureChat v2.0.2, PurePerms v2.0.2, PurePermsScore v2.0.0, RedstoneCircuit v3.0.6, RegionProtect v1.1.1, ScoreHud v7.0.1, SeeDevice v1.2.0, SellAll v1.3.0-PM4, SellMe v1.1.0, ServerTools v0.5.1, Shield v1.12.0, SimpleHubDelay v0.3, SimpleNPC v4.0.1, Spyglass v1.1.0, Sudo v1.2.1, Track v2.0.0+beta, VanillaEC v0.0.2, VanillaX v3.5.0, VanishV2 v3.1.0, WFT v1.3.5, minereset38 v0.0.1

Crashdump, backtrace or other files

[12:47:54.727] [Server thread/INFO]: Player TrialShip171896 was teleported to mine.
[12:48:05.612] [Server thread/ERROR]: [NetworkSession: TrialShip171896] Bad packet (error ID db2b37cfd2da): Error processing ItemStackRequestPacket: ItemStackRequestPacket: VarInt did not terminate after 5 bytes!
[12:48:05.628] [Server thread/INFO]: TrialShip171896 left the game
[12:48:05.635] [Server thread/INFO]: [NetworkSession: TrialShip171896] Session closed due to Packet processing error (Error ID: db2b37cfd2da)
[12:48:05.644] [RakLib thread/NOTICE]: Blocked fe80::131:62d4:703:e93e for 5 seconds
[12:48:06.105] [Server thread/INFO]: Unloading world "mine"
TukangM commented 1 year ago

image VanillaX make crash inv crafting, inv player, inv chest, inv ( is generic inv like anvilinv beaconinv enchantinv bookinv hopperinv recipeinv smithinginv stonecutterinv tradeinv)

TukangM commented 1 year ago

https://github.com/CLADevs/VanillaX/blob/4.0/src/CLADevs/VanillaX/inventories/ItemStackRequestHandler.php = ItemStackRequestPacket

TukangM commented 1 year ago

image tested vanillax only vs all plugins (related inventory plugins)

result is vanillax is make it crash

xXNiceYT commented 1 year ago

duplicate #216, but the issue because dylan didnt implement a new variable in ItemStackRequest file

TukangM commented 1 year ago

duplicate #216, but the issue because dylan didnt implement a new variable in ItemStackRequest file

ok. #216, but this is specific and might be valid so yeah. dont close