CLeARoboticsLab / MixedComplementarityProblems.jl

A custom interior point solver for mixed complementarity problems.
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Reduce dependencies #23

Closed longemen3000 closed 1 month ago

longemen3000 commented 1 month ago

This PR reduces the amount of dependencies of this package. TrajectoryGamesBase was only used for one function, while Zygote and FiniteDiff was only used for tests.

lassepe commented 1 month ago

I think these are good changes. Zygote and FiniteDiff can be removed entirely. The test directory has its own Project.toml

dfridovi commented 1 month ago

@longemen3000 looks like tests are failing on this. Once tests pass and @lassepe’s comment is addressed let’s get this merged!

dfridovi commented 1 month ago

@longemen3000 i think there’s a dependency still missing in the tests

longemen3000 commented 1 month ago

There is something wrong in the tests, that maybe is related to removing TrajectoryGamesBase.jl. I need to investigate in the meanwhile. I'm gonna close this and create another PR removing only Zygote and FiniteDiff