CMU-SAFARI / ramulator2

Ramulator 2.0 is a modern, modular, extensible, and fast cycle-accurate DRAM simulator. It provides support for agile implementation and evaluation of new memory system designs (e.g., new DRAM standards, emerging RowHammer mitigation techniques). Described in our paper https://people.inf.ethz.ch/omutlu/pub/Ramulator2_arxiv23.pdf
https://arxiv.org/abs/2308.11030
MIT License
235 stars 58 forks source link

fix bugs/typo for integerating with gem5 #33

Closed sangjae4309 closed 9 months ago

sangjae4309 commented 9 months ago

Hello, first of all, thank you for distributing this precious materials. While integrating ramulator2 with gem5, found some bugs from wrapper code and the guideline. The found bug and its modifications are as follows:

1. Some request from gem5 has no conext Id. image

Therefore, should remove refering contextId of below original code https://github.com/CMU-SAFARI/ramulator2/blob/b7c70275f04126c647edb989270cc429776955d1/resources/gem5_wrappers/ramulator2.cc#L180-L182

2. Tick event cannot move forward itself so that consecutive read operation makes simulator stuck For SPEC2006 bzip workload, after issuing 3 read operation, the simulator becomes stuck. image I found the tickEvent cannot move forward itsef. image

should change as_int to as_float https://github.com/CMU-SAFARI/ramulator2/blob/b7c70275f04126c647edb989270cc429776955d1/resources/gem5_wrappers/ramulator2.cc#L130-L131

3. While the wrapper code has debug/Ramulator2.hh , the guide doesn't tell to include DebugFlag(Ramualtor2). That mismatch can make a confue (#17)

Thank you.