COMBINE-lab / simpleaf

A rust framework to make using alevin-fry even simpler
BSD 3-Clause "New" or "Revised" License
46 stars 5 forks source link

consider making piscem a dependency in the simpleaf conda env #118

Closed rpolicastro closed 9 months ago

rpolicastro commented 11 months ago

Hello!

I was wondering if you would consider adding piscem as a dependency for simpleaf on conda.

When building pipelines it's convenient to use the conda-associated docker containers on biocontainers. Since piscem isn't a dependency for simpleaf I currently need to make a custom docker image to add it.

Cheers, Bob

rob-p commented 11 months ago

Hi @rpolicastro,

The only wrinkle there is that Apple silicon might need special handling. Do you know if it’s easy to declare an env dependency for one target but not another?

Thanks! Rob

rpolicastro commented 11 months ago

I don't have much experience building the meta files for conda, but from my understanding you can specify certain architectures for dependencies with a simple comment. As just a random example it looks like samtools excludes openssl for osx builds [recipe]. I don't know the exact syntax but something like - piscem >=0.6.3 # [not osx-arm64] would probably specifically exclude piscem for apple silicon. If piscem works on silicon with additional dependencies they could likely be included via e.g. - dependency >=1.0.0 # [osx-arm64].

rob-p commented 11 months ago

Great, thanks! A new piscem release (with decoy support and some other improvements) is imminent. We'll try this out when we push that release!

--Rob

rpolicastro commented 11 months ago

Great, I'm excited to try the shiny new features!

rob-p commented 9 months ago

Should be done!