search

COOL-cohort / COOL

the source code of the COOL system
https://www.comp.nus.edu.sg/~dbsystem/cool/
Apache License 2.0
44 stars 15 forks source link

Input cohort implementation #133

Closed KimballCai closed 1 year ago

KimballCai commented 1 year ago

This system can save cohort results in a certain format, and we need to reload these cohort results to filter users when processing other cohort queries.

NLGithubWP commented 1 year ago

This is added in this PR https://github.com/COOL-cohort/COOL/pull/106

hugy718 commented 1 year ago

CohortAnalysis implementation is wrong.

https://github.com/COOL-cohort/COOL/blob/07ce69b55db0b524ba88fa6e443bfccb8f99bb32/cool-core/src/main/java/com/nus/cool/functionality/CohortAnalysis.java#L64

It used readQueryCohorts that would load all cohorts written out. So basically all born users.

The processor also only tested that function.

https://github.com/COOL-cohort/COOL/blob/07ce69b55db0b524ba88fa6e443bfccb8f99bb32/cool-core/src/test/java/com/nus/cool/core/ProcessorTest.java#L75

Now, the all cohorts are written out by persistCohort, which is not necessary. I will restructure how persistence is done in #136 before tackling this one.

hugy718 commented 1 year ago

solved by #139